-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A5d2 nomensage enable #260
Conversation
Complex range logic for client side checkbox disable lead to using javascript instead for the NOMENSAGE behavior
hey @ashleybot , Unless im overlooking somethig, Im having a hard time replicating your result. Is it possible that the old javascript was still cached and not causing the new disable to occur in the checkboxes? |
This is incorrect:
@mlan225 |
Adding a comment about it here @ashleybot , but currently NOMENSAGE has no requirement attributes and may be a worthy of an issue card. If i am reading the documentation correctly, it appears that NOMENSAGE has a "conditional missingness", which i interpret as "will sometimes be required under certain conditions". |
@mlan225 Yep, this is correct and it would be a quick fix in this feature branch. So, the rules should follow
References
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlan225 NOMENSAGE changes look good! Good to bump to 5.0.2.
Resolves #250
Review checklist
9988 in NOMENSAGE (7b) and no checkboxes selected in 7c will not produce an error message for no selected checkboxesAllow for NOMENSAGE to be 99 and enable checkboxes in 7c of the A5D2
99 = enable checkboxes
88 = disable checkboxes
valid range error for NOMENSAGE
Validation error if no checkbox is selected when checkboxes are enabled (and NOT 99)