Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on non-x86 #158

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Fix build on non-x86 #158

merged 3 commits into from
Mar 16, 2021

Conversation

pkubaj
Copy link
Contributor

@pkubaj pkubaj commented Mar 15, 2021

cpuid is not available outside of amd64/i386.

@smmaurer
Copy link
Member

Hi @pkubaj, thanks for contributing this!

We ran into the same issue in #152. My tentative solution was to drop the #include itself, because it doesn't seem like HyperThreading.h is actually used by the current code.

But your solution of refining the #ifdef is more conservative, so I'm inclined to go with this. I'll run a couple of tests and then merge this.

@smmaurer smmaurer merged commit 4bacf4c into UDST:dev Mar 16, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants