Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-3043 Add z-index to dropdown button #673

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: APPS-3043 Add z-index to dropdown button #673

merged 1 commit into from
Jan 7, 2025

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Jan 7, 2025 •
edited
Loading

Connected to APPS-3043

Component Updated: ButtonDropdown.vue

Notes:

  • Fixed page/rich-text content overlaying on top of share button dropdown links

Local Nuxt Previews:

overlay-before

overlay-after

overlay2-before

overlay2-after

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the fix label Jan 7, 2025
@tinuola tinuola self-assigned this Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🚀 Deployed on https://deploy-preview-673--ucla-library-storybook.netlify.app

pghorpade
pghorpade approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit 4250fe3 into main Jan 7, 2025
15 checks passed
@pghorpade pghorpade deleted the APPS-3043_fix-share-btn-zIndex branch January 7, 2025 21:45
pghorpade pushed a commit that referenced this pull request Jan 7, 2025
@semantic-release-bot
chore(release): set package.json to 3.43.6 [skip ci]
a36d72a 
## [3.43.6](v3.43.5...v3.43.6) (2025-01-07)

### Bug Fixes

* APPS-3043 Add z-index to dropdown button ([#673](#673)) ([4250fe3](4250fe3))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.43.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghorpade pghorpade pghorpade approved these changes

Assignees

@tinuola tinuola

Labels
fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinuola @pghorpade