Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-3042 Embedded video height in RichText #672

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Jan 3, 2025

Connected to APPS-3042

Component Created: RichText.vue

Notes:

  • Updated the height setting for iframe videos embedded in RichText to preserve their height

Local Nuxt Previews:
Before:
embedded-iframe_before

After:
embedded-iframe_after

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I requested a PR review from the Dev team
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the fix label Jan 3, 2025
@tinuola tinuola self-assigned this Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pghorpade pghorpade merged commit 819a6ba into main Jan 7, 2025
15 checks passed
@pghorpade pghorpade deleted the APPS-3042_fix-embed-video-mobile-height branch January 7, 2025 17:29
pghorpade pushed a commit that referenced this pull request Jan 7, 2025
## [3.43.5](v3.43.4...v3.43.5) (2025-01-07)

### Bug Fixes

* APPS-3042 Embedded video height in RichText ([#672](#672)) ([819a6ba](819a6ba))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.43.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants