Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-3117 Additional Component Fixes for EventListing Page #671

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: APPS-3117 Additional Component Fixes for EventListing Page #671

merged 2 commits into from
Dec 20, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Dec 19, 2024 •
edited
Loading

Connected to APPS-3117

Components Updated: BaseCalendar.vue, BlockCardThreeColumn.vue

Notes:

  • Minor style/CSS updates to:
    • Add border-radius to the bottom corners of calendar popup card
    • Remove excess padding in tab labels/pills in 3-column-card component

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • [ ] I checked that it is working locally in the library-website-nuxt dev server
  • [ ] I added a screenshot of it working
  • UX has reviewed and approved this
  • I have requested a PR review from the Dev team
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the fix label Dec 19, 2024
@tinuola tinuola self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-671--ucla-library-storybook.netlify.app

@tinuola tinuola merged commit 385665a into main Dec 20, 2024
15 checks passed
@tinuola tinuola deleted the APPS-3117_component-fixes-event-listing-pg branch December 20, 2024 18:06
pghorpade pushed a commit that referenced this pull request Dec 20, 2024
@semantic-release-bot
chore(release): set package.json to 3.43.4 [skip ci]
faac68a 
## [3.43.4](v3.43.3...v3.43.4) (2024-12-20)

### Bug Fixes

* APPS-3117 Additional Component Fixes for EventListing Page ([#671](#671)) ([385665a](385665a))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.43.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farosFreed farosFreed farosFreed approved these changes

Assignees

@tinuola tinuola

Labels
fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinuola @pghorpade @farosFreed