Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: APPS-3112 unify styles between datefilter and filterdropdown #669

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Dec 18, 2024

Connected to APPS-3112

Notes:

When implementing filters side by side on event listing page we noticed style differences. This PR will unify the styles between the 2.

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@farosFreed farosFreed self-assigned this Dec 18, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@farosFreed farosFreed changed the title chore: unify styles between datefilter and filterdropdown chore: APPS-3112 unify styles between datefilter and filterdropdown Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-669 December 18, 2024 23:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-669 December 18, 2024 23:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-669 December 19, 2024 17:20 Inactive
@tinuola tinuola merged commit cee21bd into main Dec 19, 2024
9 of 10 checks passed
@tinuola tinuola deleted the APPS-3112_style_fixes branch December 19, 2024 20:10
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.43.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants