Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS 3080 Update TabList buttons with SEO logic #667

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Dec 12, 2024

Connected to APPS-3080, APPS-3077

Component Updated: TabList.vue

Notes:

  • Update TabList code to make tab buttons SEO friendly
  • Add dynamic routing to update browser URL without reloading the page
  • Detect the active tab from the URL

Checklist:

  • I checked that it is working locally in the dev server
  • [ ] I checked that it is working locally in the storybook
  • [ ] I checked that it is working locally in the library-website-nuxt dev server
  • [ ] I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the enhancement New feature or request label Dec 12, 2024
@tinuola tinuola self-assigned this Dec 12, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Dec 12, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-667 December 12, 2024 18:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-667 December 13, 2024 05:32 Inactive
@tinuola tinuola force-pushed the APPS-3080_tablist-btns-seo branch from eada785 to 40f2247 Compare December 13, 2024 20:28
@github-actions github-actions bot temporarily deployed to storybook--pull_request-667 December 13, 2024 20:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-667 December 13, 2024 20:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-667 December 13, 2024 20:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-667 December 13, 2024 21:13 Inactive
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work

@farosFreed farosFreed merged commit de1c8fa into main Dec 13, 2024
9 checks passed
@farosFreed farosFreed deleted the APPS-3080_tablist-btns-seo branch December 13, 2024 22:42
pghorpade pushed a commit that referenced this pull request Dec 13, 2024
## [3.43.1](v3.43.0...v3.43.1) (2024-12-13)

### Bug Fixes

* APPS 3080 Update TabList buttons with SEO logic ([#667](#667)) ([de1c8fa](de1c8fa))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.43.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants