chore: add a test for datefilter emit behavior #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-665
github-actions
bot
temporarily deployed
to
storybook--pull_request-665
tinuola
approved these changes
Dec 11, 2024
|
🎉 This PR is included in version 3.43.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3099
Stories: ~/stories/DateFilter.stories.js
Spec: ~/stories/DateFilter.spec.js
Notes:
This PR addresses some tech debt that I left behind while making changes to the DateFilter component for APPS-3073.
This PR edits the default datefilter story to display the currently selected date object.
It also adds a test to check that the date display is updated after a date is selected and done is clicked, but not before.
Here is the slack thread for full context
Checklist:
[ ] I checked that it is working locally in thelibrary-website-nuxt dev server
[ ] I added a screenshot of it working[ ] UX has reviewed and approved this