feat: Apps-3035 create filters drop down component #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
github-actions
bot
temporarily deployed
to
storybook--pull_request-664
pghorpade
pushed a commit
that referenced
this pull request
Dec 13, 2024
# [3.42.0](v3.41.0...v3.42.0) (2024-12-13) ### Features * Apps-3035 create filters drop down component ([#664](#664)) ([8dbad4a](8dbad4a))
|
🎉 This PR is included in version 3.42.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3035
Component Created: FiltersDropdown.vue based on this component request
Stories: ~/stories/FiltersDropdown.stories.js
Spec: ~/stories/FiltersDropdown.spec.js
Notes:
This PR adds the FiltersDropdown.vue component to the component library, along with its styles, test, and story files.
This component currently uses v-model which cuts down on script needed.
Because a child's v-model data is always in sync with the parent's model variable, I did not include emits yet despite them being mentioned in the requirements, as I don't believe they will do anything. However, if we need the parent data to be in a different state than the v-model data, we can use the pattern of assigning an initial data prop to a data ref and then emitting to the parent when we want it to update the data. This is somewhat what
dateFilter.vuedoes.Checklist:
library-website-nuxt dev server