Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-3078 add is highlighted to blockcardthreecolumn #662

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Dec 5, 2024

Connected to APPS-3078

Component Updated: BlockCardThreeColumn.vue

Stories Updated: ~/stories/BlockCardThreeColumn.vue.stories.js

Notes:

This is PR 1 of 2 to implement APPS-3078, which adds the isHighlighted prop on BlockCardThreeColumn and later on the data for the page.

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • [ ] I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@farosFreed farosFreed added the feature feature label Dec 5, 2024
@farosFreed farosFreed self-assigned this Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-662 December 5, 2024 21:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-662 December 12, 2024 19:46 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-662 December 12, 2024 19:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-662 December 12, 2024 19:52 Inactive
@farosFreed farosFreed marked this pull request as ready for review December 12, 2024 19:53
@farosFreed
Copy link
Contributor Author

Screenshot 2024-12-12 at 12 56 05 PM

@github-actions github-actions bot temporarily deployed to storybook--pull_request-662 December 13, 2024 16:55 Inactive
@tinuola tinuola merged commit 32758a6 into main Dec 13, 2024
9 checks passed
@tinuola tinuola deleted the APPS-3078_add-highlighted-state branch December 13, 2024 21:12
pghorpade pushed a commit that referenced this pull request Dec 13, 2024
# [3.43.0](v3.42.0...v3.43.0) (2024-12-13)

### Features

* APPS-3078 add is highlighted to blockcardthreecolumn ([#662](#662)) ([32758a6](32758a6))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.43.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants