-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APPS 3079 Calendar Component EventCard Popup #661
Conversation
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
f30915b
to
5f6fe61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really amazing work on this component. It's beautiful!
I have made a few comments to help with the implementation of the isHighlighted blockTags, which will hopefully eliminate the need for https://uclalibrary.atlassian.net/jira/software/c/projects/APPS/boards/12?issueParent=188411%2C190145%2C195701%2C195704&selectedIssue=APPS-3087
I am still working on the issue with the fixed height and the arrows, I will add more comments on that in a little bit
ee2875f
to
28ae275
Compare
4dc06c6
to
5648f28
Compare
5648f28
to
c1aefbe
Compare
c1aefbe
to
e92ed66
Compare
e92ed66
to
ae31dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work on this!
# [3.40.0](v3.39.2...v3.40.0) (2024-12-10) ### Features * APPS 3079 Calendar Component EventCard Popup ([#661](#661)) ([dc24f85](dc24f85))
🎉 This PR is included in version 3.40.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Connected to APPS-3049, APPS-3079
Component Updated:
Stories: ~/stories/BaseCalendar.stories.js
Notes:
Deploy previews:
Local Nuxt screenshot:
Checklist:
library-website-nuxt dev server