Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS 3079 Calendar Component EventCard Popup #661

Merged
merged 37 commits into from
Dec 10, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Nov 27, 2024

Connected to APPS-3049, APPS-3079

Component Updated:

  • BaseCalendar.vue
  • CardMeta.vue

Stories: ~/stories/BaseCalendar.stories.js

Notes:

  • Implemented calendar event item dialog/popup
  • Added slot option to allow for future use with alternate inner components
  • Updated styling
  • Updated stories
  • Slight modification to CardMeta to conditionally remove empty slot that was adding excess space

Deploy previews:


Local Nuxt screenshot:

nuxt-calendar-preview

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I have requested a PR review from the Dev team
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the feature feature label Nov 27, 2024
@tinuola tinuola self-assigned this Nov 27, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 November 27, 2024 22:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 4, 2024 22:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 00:03 Inactive
@tinuola tinuola changed the title wip: APPS 3079 Calendar Component EventCard Popup feat: APPS 3079 Calendar Component EventCard Popup Dec 5, 2024
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 03:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 17:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 17:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 17:14 Inactive
@tinuola tinuola force-pushed the APPS-3079_calendar-component-event-popup branch from f30915b to 5f6fe61 Compare December 5, 2024 17:56
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 17:57 Inactive
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work on this component. It's beautiful!

I have made a few comments to help with the implementation of the isHighlighted blockTags, which will hopefully eliminate the need for https://uclalibrary.atlassian.net/jira/software/c/projects/APPS/boards/12?issueParent=188411%2C190145%2C195701%2C195704&selectedIssue=APPS-3087

I am still working on the issue with the fixed height and the arrows, I will add more comments on that in a little bit

src/stories/mock/CalendarEvents.js Outdated Show resolved Hide resolved
src/lib-components/BaseCalendar.vue Show resolved Hide resolved
src/styles/ftva/_base-calendar.scss Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 5, 2024 23:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 6, 2024 16:06 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 6, 2024 17:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 6, 2024 19:03 Inactive
@tinuola tinuola force-pushed the APPS-3079_calendar-component-event-popup branch from ee2875f to 28ae275 Compare December 6, 2024 19:13
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 6, 2024 19:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 10, 2024 21:54 Inactive
@tinuola tinuola force-pushed the APPS-3079_calendar-component-event-popup branch from 4dc06c6 to 5648f28 Compare December 10, 2024 21:59
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 10, 2024 22:00 Inactive
@tinuola tinuola force-pushed the APPS-3079_calendar-component-event-popup branch from 5648f28 to c1aefbe Compare December 10, 2024 22:24
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 10, 2024 22:26 Inactive
@tinuola tinuola force-pushed the APPS-3079_calendar-component-event-popup branch from c1aefbe to e92ed66 Compare December 10, 2024 22:37
@github-actions github-actions bot temporarily deployed to storybook--pull_request-661 December 10, 2024 22:39 Inactive
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this!

@farosFreed farosFreed merged commit dc24f85 into main Dec 10, 2024
11 checks passed
@farosFreed farosFreed deleted the APPS-3079_calendar-component-event-popup branch December 10, 2024 23:52
pghorpade pushed a commit that referenced this pull request Dec 10, 2024
# [3.40.0](v3.39.2...v3.40.0) (2024-12-10)

### Features

* APPS 3079 Calendar Component EventCard Popup ([#661](#661)) ([dc24f85](dc24f85))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.40.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants