fix: APPS-3073 Datefilter bugs & enhancements #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-660
github-actions
bot
temporarily deployed
to
storybook--pull_request-660
github-actions
bot
temporarily deployed
to
storybook--pull_request-660
github-actions
bot
temporarily deployed
to
storybook--pull_request-660
github-actions
bot
temporarily deployed
to
storybook--pull_request-660
github-actions
bot
temporarily deployed
to
storybook--pull_request-660
pghorpade
pushed a commit
that referenced
this pull request
Dec 6, 2024
## [3.39.1](v3.39.0...v3.39.1) (2024-12-06) ### Bug Fixes * APPS-3073 Datefilter bugs & enhancements ([#660](#660)) ([64b7825](64b7825))
|
🎉 This PR is included in version 3.39.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3073
Component Created: DateFilter.vue
Stories: ~/stories/DateFilter.stories.js
Spec: ~/stories/DateFilter.spec.js
Notes:
In progress, just starting
Work Breaks down into 2 categories:
[X] Make sure emits only happen on done & clear click, and make sure they include date formatted as needed
I had wanted to cover this with some tests, but I went down a whole rabbit hole trying to get cypress to let me detect emits from a component, which I never fully solved. Here is the slack conversation. I would like to go back and solve this soon as part of a Learning Monday, since I have already spent so much time on this task.
[X] Make sure component does not throw errors / fail when moving between mobile & desktop
We accomplish this by clearing the date selection on screen resize
Checklist:
library-website-nuxt dev server
[ ] UX has reviewed and approved this