feat: APPS-3045 refactor mobile drawer, datefilter mobile #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
farosFreed
changed the title
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
Screenshot of the drawer. The Calendar button styles will be tweaked a bit to match UX specs |
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
github-actions
bot
temporarily deployed
to
storybook--pull_request-654
pghorpade
approved these changes
Nov 22, 2024
pghorpade
pushed a commit
that referenced
this pull request
Nov 26, 2024
# [3.36.0](v3.35.1...v3.36.0) (2024-11-26) ### Features * APPS-3045 refactor mobile drawer, datefilter mobile ([#654](#654)) ([3301d47](3301d47))
|
🎉 This PR is included in version 3.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-3045
Component Created: MobileDrawer.vue
Stories: ~/stories/MobileDrawer.stories.js
Spec: ~/stories/MobileDrawer.spec.js
Notes:
Work done:
Not done:
factor component into its own file
DateFilter.vue had to be duplicated in the template to get it to fit into our mobile designs (it shows in one spot if we are on mobile, a different spot if we aren't).
To prevent duplicating the code, I had wanted to refactor our implementation to put the code in its own component, thus making it easier/shorter to duplicate that component. However, I stopped because the MobileDrawer component needs to pass a removeOverlay method to a specific button on the VueDatePicker to allow it to close the drawer, and I could not figure out how to pass this slot meothd through that many layers without the VueDatePicker button and the MobileDrawer being in the same file.
I'm happy to go back to it if anyone has ideas.
Checklist:
ftva-website-nuxt dev server