Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-3041 Reset TwoCol component primary column width #646

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: APPS-3041 Reset TwoCol component primary column width #646

merged 2 commits into from
Oct 25, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 25, 2024 •
edited
Loading

Connected to APPS-3041

Component Created: TwoColLayoutWStickySidebar.vue

Notes:

  • Reset primary column width at updated tablet breakpoint range

reset-primary-col-width

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review~~
  • I used a conventional commit message~~
  • I assigned myself to this PR~~

@tinuola tinuola added the fix label Oct 25, 2024
@tinuola tinuola self-assigned this Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-646--ucla-library-storybook.netlify.app

@github-actions github-actions bot temporarily deployed to storybook--pull_request-646 October 25, 2024 17:25 Inactive
farosFreed
farosFreed approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks!

@tinuola tinuola merged commit aab79c2 into main Oct 25, 2024
11 checks passed
@tinuola tinuola deleted the APPS-3041_update-twoColumn-primary-width branch October 25, 2024 19:46
pghorpade pushed a commit that referenced this pull request Oct 25, 2024
@semantic-release-bot
chore(release): set package.json to 3.31.4 [skip ci]
94cd2ed 
## [3.31.4](v3.31.3...v3.31.4) (2024-10-25)

### Bug Fixes

* APPS-3041 Reset TwoCol component primary column width ([#646](#646)) ([aab79c2](aab79c2))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.31.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farosFreed farosFreed farosFreed approved these changes

Assignees

@tinuola tinuola

Labels
fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinuola @pghorpade @farosFreed