Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-3040 bold is not working in FTVA RichText #645

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Oct 24, 2024

Connected to APPS-3040

https://deploy-preview-645--ucla-library-storybook.netlify.app/?path=/docs/global-rich-text--docs

Notes:

  1. Update Proxima Nova fonts in the Design Tokens PR-123
  2. package.json & pnpm-lock.yaml
    • Update design-token library
  3. src/stories/mock/RichText.js
    • Update associated stories with bolded text to test that the fix is working
  4. src/styles/ftva/_rich-text.scss
    • Update the ftva/RichText.css to include font-weight: 600 for the strong html element
  5. It is also working in the FTVA Flexible/RichText

Checklist:

  • UX has reviewed and approved this

  • I checked that it is working locally in the locally linked, library-website-nuxt dev server

Screenshot 2024-10-24 at 5 57 04 PM
  • I checked that it is working locally in the storybook
Screenshot 2024-10-24 at 5 36 02 PM

Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-645 October 24, 2024 22:15 Inactive
@jendiamond jendiamond changed the title update ftvaRichText css, stories & design-tokens fix: APPS-3040 bold is not working in FTVA RichText Oct 25, 2024
@jendiamond jendiamond added the fix label Oct 25, 2024
@jendiamond jendiamond self-assigned this Oct 25, 2024
@github-actions github-actions bot temporarily deployed to storybook--pull_request-645 October 25, 2024 00:51 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jendiamond jendiamond merged commit 202f70a into main Oct 29, 2024
9 checks passed
@jendiamond jendiamond deleted the rich-text-bold-fix branch October 29, 2024 19:06
pghorpade pushed a commit that referenced this pull request Oct 29, 2024
## [3.31.5](v3.31.4...v3.31.5) (2024-10-29)

### Bug Fixes

* APPS-3040 bold is not working in FTVA RichText ([#645](#645)) ([202f70a](202f70a))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.31.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants