Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APPS 2793 Add selected state to FTVA filters #642

Merged
merged 3 commits into from
Oct 22, 2024
Merged

feat: APPS 2793 Add selected state to FTVA filters #642

merged 3 commits into from
Oct 22, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 22, 2024 •
edited
Loading

Connected to APPS-2793

Component Created: BlockRemoveSearchFilter.vue

Notes:

  • Added isSelected prop
  • Updated code logic (class and template) and CSS
    • Filter expands and has x icon if selected; no longer expands on hover
  • Added extra story to depict selected state

Previews:

Default
default

Hover
hover

Selected
selected


Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • [ ] I checked that it is working locally in the library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the enhancement New feature or request label Oct 22, 2024
@tinuola tinuola self-assigned this Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-642--ucla-library-storybook.netlify.app

@github-actions github-actions bot temporarily deployed to storybook--pull_request-642 October 22, 2024 21:24 Inactive
@tinuola tinuola changed the title Apps 2793 update ftva filter state feat: APPS 2793 Add selected state to FTVA filters Oct 22, 2024
jendiamond
jendiamond approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jendiamond jendiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎃

@jendiamond jendiamond merged commit 630b584 into main Oct 22, 2024
11 checks passed
@jendiamond jendiamond deleted the APPS-2793_update-ftva-filter-state branch October 22, 2024 22:19
pghorpade pushed a commit that referenced this pull request Oct 22, 2024
@semantic-release-bot
chore(release): set package.json to 3.30.0 [skip ci]
e068fb1 
# [3.30.0](v3.29.7...v3.30.0) (2024-10-22)

### Features

* APPS 2793 Add selected state to FTVA filters ([#642](#642)) ([630b584](630b584))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jendiamond jendiamond jendiamond approved these changes

Assignees

@tinuola tinuola

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinuola @pghorpade @jendiamond