Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-2976 & APPS-3011 Updates to cardMeta - category & aboutAuthor #639

Merged
merged 10 commits into from
Oct 24, 2024
Merged

fix: APPS-2976 & APPS-3011 Updates to cardMeta - category & aboutAuthor #639

merged 10 commits into from
Oct 24, 2024

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Oct 18, 2024 •
edited by jira bot
Loading

Connected to:

  • APPS-2976 - Category in CardMeta should link to Series entry
  • APPS-3011 - BlogDetail move aboutAuthor out of CardMeta into RichText component to fix truncation

STORY - FtvaLinkedCategoryAndTitle:
https://deploy-preview-639--ucla-library-storybook.netlify.app/?path=/story/card-meta--ftva-linked-category-and-title

Notes:
This is a two part PR. Updates need to be made in ftva-website-nuxt also.

  1. src/lib-components/CardMeta.vue
    • Add linked-category slot to CardMeta
    • Delete about-author from CardMeta
  2. src/stories/CardMeta.stories.js
    • Add FtvaLinkedCategoryAndTitle story for linked-category slot
    • Delete about-author from the story
  3. src/styles/ftva/_card-meta.scss
    • Add styling for linked-category slot
    • Delete about-author from stories

Checklist:

  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this

Screenshot 2024-10-23 at 9 35 27 AM

Screenshot 2024-10-23 at 9 34 33 AM

@jendiamond jendiamond added the fix label Oct 18, 2024
@jendiamond jendiamond self-assigned this Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-639--ucla-library-storybook.netlify.app

@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 18, 2024 22:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 18, 2024 23:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 18, 2024 23:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 22, 2024 20:24 Inactive
@jendiamond jendiamond force-pushed the card-meta_APPS-3011_fix-about-author_APPS-2976_link-category-in-event-detail branch from 9ac92fe to 282e9f2 Compare October 23, 2024 05:18
@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 23, 2024 05:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 23, 2024 05:28 Inactive
@jendiamond jendiamond mentioned this pull request Oct 23, 2024
Merged
3 tasks
@jendiamond jendiamond changed the title fix: APPS-2976 & APPS-3011 updates to cardMeta fix: APPS-2976 & APPS-3011 Updates to cardMeta - category & aboutAuthor Oct 23, 2024
@jendiamond jendiamond force-pushed the card-meta_APPS-3011_fix-about-author_APPS-2976_link-category-in-event-detail branch from 878351f to 335b199 Compare October 23, 2024 21:54
@github-actions github-actions bot temporarily deployed to storybook--pull_request-639 October 23, 2024 21:56 Inactive
pghorpade
pghorpade approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit 67aaadd into main Oct 24, 2024
9 checks passed
@pghorpade pghorpade deleted the card-meta_APPS-3011_fix-about-author_APPS-2976_link-category-in-event-detail branch October 24, 2024 17:52
pghorpade pushed a commit that referenced this pull request Oct 24, 2024
@semantic-release-bot
chore(release): set package.json to 3.31.1 [skip ci]
72ebbde 
## [3.31.1](v3.31.0...v3.31.1) (2024-10-24)

### Bug Fixes

* APPS-2976 & APPS-3011 Updates to cardMeta - category & aboutAuthor ([#639](#639)) ([67aaadd](67aaadd))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghorpade pghorpade pghorpade approved these changes

Assignees

@jendiamond jendiamond

Labels
fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jendiamond @pghorpade