fix: APPS-2972 Reformat dates to exclude the leading zero on single digit dates #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…date the story to contain one
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-638
farosFreed
requested changes
Oct 18, 2024
There was a problem hiding this comment.
I am concerned the BlockClippedDate default styles will be impacted by this. Please either revert the change to the shared util file and format the date directly in your component as needed, OR add a story for BlockClippedDate that adds a date starting with 0 and make sure it looks OK
…ing-zero-on-single-digit-dates
github-actions
bot
temporarily deployed
to
storybook--pull_request-638
github-actions
bot
temporarily deployed
to
storybook--pull_request-638
github-actions
bot
temporarily deployed
to
storybook--pull_request-638
github-actions
bot
temporarily deployed
to
storybook--pull_request-638
…ing-zero-on-single-digit-dates
github-actions
bot
temporarily deployed
to
storybook--pull_request-638
farosFreed
approved these changes
Oct 22, 2024
farosFreed
deleted the
APPS-2972_reformat-dates-to-exclude-the-leading-zero-on-single-digit-dates
branch
pghorpade
pushed a commit
that referenced
this pull request
Oct 22, 2024
## [3.29.7](v3.29.6...v3.29.7) (2024-10-22) ### Bug Fixes * APPS-2972 Reformat dates to exclude the leading zero on single digit dates ([#638](#638)) ([76b7155](76b7155))
|
🎉 This PR is included in version 3.29.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2972
Test for the Single Digit on Block Clipped Date
Notes:
src/utils/formatEventDay.jssrc/stories/SectionTeaserList.stories.js+.update this story to contain a date with a single digit
Checklist:
library-website-nuxt dev server