Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APPS-3004 Fix Location links in component BlockEventDetail #635

Merged
merged 20 commits into from
Oct 18, 2024
Merged

fix: APPS-3004 Fix Location links in component BlockEventDetail #635

merged 20 commits into from
Oct 18, 2024

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Oct 16, 2024 •
edited
Loading

Connected to APPS-3004

https://deploy-preview-635--ucla-library-storybook.netlify.app/?path=/story/block-event-detail--default

Notes:

  1. src/lib-components/BlockEventDetail.vue
    • Add publicUrl?: string to the list of potential
    • Add a new line between the span tags
    • Fixes the Links: Changed from :to="location.title" to :to="locations[0].publicUrl" or :to="locations[0].url"
    • Adds 'parsedTarget` to have the link go to another page if external
  2. src/stories/BlockEventDetail.stories.js
    • Updates the stories for default and FTVA

Checklist:

  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this

ONE LOCATION:

Screenshot 2024-10-16 at 12 11 27 PM

NO LOCATION:

Screenshot 2024-10-16 at 12 12 11 PM

MULTIPLE LOCATIONS:

Screenshot 2024-10-16 at 12 10 26 PM

@jendiamond jendiamond added the fix label Oct 16, 2024
@jendiamond jendiamond self-assigned this Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-635--ucla-library-storybook.netlify.app

@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 17:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 18:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 18:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 18:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 19:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 20:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 20:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 20:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 16, 2024 21:01 Inactive
pghorpade
pghorpade previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixes 💯

@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 18:02 Inactive
@jendiamond
update the specs to load the fonts before the snapshot in these compo…
3470a9e 
…nents BannerFeatured, ButtonShow, Flexible_CardWithImage, Flexible_MediaWithText
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 18:45 Inactive
@jendiamond
update the specs to load the fonts before the snapshot in these compo…
e53597a 
…nents BannerFeatured, ButtonShow, Flexible_CardWithImage, Flexible_MediaWithText
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 19:21 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 19:33 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 21:14 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 22:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-635 October 17, 2024 23:03 Inactive
pghorpade
pghorpade approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for trying to fix the font loading issue with percy

@pghorpade pghorpade merged commit 5546329 into main Oct 18, 2024
9 checks passed
@pghorpade pghorpade deleted the APPS-3004_fix-location-links-in--block-event-detail branch October 18, 2024 02:26
pghorpade pushed a commit that referenced this pull request Oct 18, 2024
@semantic-release-bot
chore(release): set package.json to 3.29.2 [skip ci]
7253d90 
## [3.29.2](v3.29.1...v3.29.2) (2024-10-18)

### Bug Fixes

* APPS-3004 Fix Location links in component BlockEventDetail ([#635](#635)) ([5546329](5546329))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.29.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

pghorpade pushed a commit that referenced this pull request Oct 22, 2024
@jendiamond @pghorpade
fix: APPS-3004 Fix Location links in component BlockEventDetail (#635)
d10eabc 
* update stories & component

* fix default links

* update default links

* update default links

* update target-link to blank

* linting

* update == to ===

* Fix linting errors

* fix parsedTheme

* load fonts to percy before snapshot is taken in BlockDetail & RchText

* update the specs to load the fonts before the snapshot in these components BannerFeatured, ButtonShow, Flexible_CardWithImage, Flexible_MediaWithText

* update the specs to load the fonts before the snapshot in these components BannerFeatured, ButtonShow, Flexible_CardWithImage, Flexible_MediaWithText

* add cypress custom command and update specs

* add another lint in the files to wait for the fonts

* trying waitForFonts

* trying waitForFonts

* update the preview ts to vue decorator

* revert all changes that tried to fix the percy snapshot to preload the fonts

* revert all changes that tried to fix the percy snapshot to preload the fonts

* revert all changes that tried to fix the percy snapshot to preload the fonts
pghorpade pushed a commit that referenced this pull request Oct 22, 2024
@semantic-release-bot @pghorpade
chore(release): set package.json to 3.29.2 [skip ci]
a32a6c3 
## [3.29.2](v3.29.1...v3.29.2) (2024-10-18)

### Bug Fixes

* APPS-3004 Fix Location links in component BlockEventDetail ([#635](#635)) ([5546329](5546329))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghorpade pghorpade pghorpade approved these changes

Assignees

@jendiamond jendiamond

Labels
fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jendiamond @pghorpade