Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APPS-3007 Use RichText comp in BlockCTA comp #634

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 15, 2024

Connected to APPS-3007

Component Created: BlockCallToAction.vue

Notes:

  • Replaced use of parsed-text-handlebar template with RichText component
  • Updated CSS

Preview:

default

hover


Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I have requested a PR review from the Dev team
  • I used a conventional commit message
  • I assigned myself to this PR

@tinuola tinuola added the fix label Oct 15, 2024
@tinuola tinuola self-assigned this Oct 15, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-634 October 15, 2024 23:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-634 October 18, 2024 03:38 Inactive
@tinuola tinuola force-pushed the APPS-3007_update-ftva-block-cta branch from a21600b to 691788d Compare October 18, 2024 18:39
@github-actions github-actions bot temporarily deployed to storybook--pull_request-634 October 18, 2024 18:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-634 October 18, 2024 20:44 Inactive
Copy link
Contributor

@farosFreed farosFreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, looks good to me

@github-actions github-actions bot temporarily deployed to storybook--pull_request-634 October 18, 2024 22:11 Inactive
@farosFreed
Copy link
Contributor

Holding off on merge until this question can be resolved https://uclalibrary.slack.com/archives/C014BPS0YBX/p1729289154846649

@farosFreed farosFreed merged commit 42adaea into main Oct 22, 2024
9 checks passed
@farosFreed farosFreed deleted the APPS-3007_update-ftva-block-cta branch October 22, 2024 18:54
pghorpade pushed a commit that referenced this pull request Oct 22, 2024
## [3.29.6](v3.29.5...v3.29.6) (2024-10-22)

### Bug Fixes

* APPS-3007 Use RichText comp in BlockCTA comp ([#634](#634)) ([42adaea](42adaea))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.29.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants