Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APPS-2954 MultiComponent update with DateCreated prop #625

Merged
merged 10 commits into from
Oct 2, 2024
Merged

feat: APPS-2954 MultiComponent update with DateCreated prop #625

merged 10 commits into from
Oct 2, 2024

Conversation

tinuola
Copy link
Contributor

@tinuola tinuola commented Oct 1, 2024 •
edited
Loading

Connected to APPS-2954

Component Updated: BlockCardWithImage.vue, CardMeta.vue, SectionTeaserCard.vue

Stories: ~/stories/BlockCardWithImage.stories.js, ~/stories/SectionTeaserCard.stories.js

Notes:

  • Add dateCreated prop to BlockCardWithImage component; update the component in SectionTeaserCard
  • Slight update to CardMeta byline group logic to allow date to show without a byline
  • CSS updates

Previews:

Local Nuxt
ftva-nuxt-blog-series-cards

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I have requested a PR review from the dev team
  • I used a conventional commit message
  • I assigned myself to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-625--ucla-library-storybook.netlify.app

@github-actions github-actions bot temporarily deployed to storybook--pull_request-625 October 1, 2024 21:33 Inactive
@tinuola tinuola self-assigned this Oct 1, 2024
@tinuola tinuola added the enhancement New feature or request label Oct 1, 2024
@github-actions github-actions bot temporarily deployed to storybook--pull_request-625 October 1, 2024 21:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-625 October 1, 2024 22:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-625 October 1, 2024 23:03 Inactive
@farosFreed farosFreed merged commit 316a316 into main Oct 2, 2024
9 checks passed
@farosFreed farosFreed deleted the APPS-2954_multiComponent-update-with-dateCreated-prop branch October 2, 2024 15:56
pghorpade pushed a commit that referenced this pull request Oct 2, 2024
@semantic-release-bot
chore(release): set package.json to 3.26.0 [skip ci]
2bb74e3 
# [3.26.0](v3.25.0...v3.26.0) (2024-10-02)

### Features

* APPS-2954 MultiComponent update with DateCreated prop ([#625](#625)) ([316a316](316a316))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farosFreed farosFreed farosFreed approved these changes

Assignees

@tinuola tinuola

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinuola @pghorpade @farosFreed