Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APPS-2956 flexible-divider-way finder #621

Merged
merged 10 commits into from
Sep 27, 2024
Merged

feat: APPS-2956 flexible-divider-way finder #621

merged 10 commits into from
Sep 27, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Sep 25, 2024 •
edited
Loading

Connected to APPS-2956

Component Created:/Flexible/HorizontalDivider.vue

Stories: ~/stories/FlexibleHorizontalDivider.stories.js

Spec: ~/stories/FlexibleHorizontalDivider.spec.js

Notes:

In progress! Need to add prop for true/false and display based on that

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • [ ] UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@farosFreed farosFreed self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@farosFreed farosFreed added the feature feature label Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-621--ucla-library-storybook.netlify.app

@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 25, 2024 21:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 27, 2024 00:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 27, 2024 15:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 27, 2024 16:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 27, 2024 17:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 27, 2024 17:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-621 September 27, 2024 17:40 Inactive
@farosFreed farosFreed marked this pull request as ready for review September 27, 2024 18:11
pghorpade
pghorpade approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 looks good

@pghorpade pghorpade merged commit 125cfe7 into main Sep 27, 2024
9 checks passed
@pghorpade pghorpade deleted the APPS-2956_Flexibile_dividerwayfinder branch September 27, 2024 18:51
pghorpade pushed a commit that referenced this pull request Sep 27, 2024
@semantic-release-bot
chore(release): set package.json to 3.24.0 [skip ci]
9996110 
# [3.24.0](v3.23.0...v3.24.0) (2024-09-27)

### Features

*  APPS-2956 flexible-divider-way finder ([#621](#621)) ([125cfe7](125cfe7))
* APPS-2916 fix hydration and undefined errors ([#623](#623)) ([03c8948](03c8948)), closes [#611](#611)
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pghorpade pghorpade pghorpade approved these changes

Assignees

@farosFreed farosFreed

Labels
feature feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farosFreed @pghorpade