fix: APPS-2982 Remove excess padding values #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
|
github-actions
bot
temporarily deployed
to
storybook--pull_request-620
farosFreed
approved these changes
Sep 25, 2024
pghorpade
pushed a commit
that referenced
this pull request
Sep 25, 2024
## [3.22.1](v3.22.0...v3.22.1) (2024-09-25) ### Bug Fixes * APPS-2982 Remove excess padding values ([#620](#620)) ([d895d3c](d895d3c))
|
🎉 This PR is included in version 3.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
pghorpade
pushed a commit
that referenced
this pull request
Sep 27, 2024
* fix: remove excess padding values * adjust responsiveness of fix --------- Co-authored-by: tinuola <[email protected]>
pghorpade
pushed a commit
that referenced
this pull request
Sep 27, 2024
## [3.22.1](v3.22.0...v3.22.1) (2024-09-25) ### Bug Fixes * APPS-2982 Remove excess padding values ([#620](#620)) ([d895d3c](d895d3c))
pghorpade
added a commit
that referenced
this pull request
Sep 27, 2024
* feat: set ref ismobile to false and update it in onmounted client side * fix: hydration error and undefined errors by adding watchers * fix: replace globalstore with useWindowSize from vueuse , also revert iconwithlink and section-wrapper changes not needed in this PR and add watcher to update layout data when nuxt needs to work with craft draft previews * feat: APPS-2943 Add initialTab setting option to TabToggle (#611) * wip: add prop for initialTab selection * refactor glider animation to work with setting intial tab position * remove margin value on glider/offset * add story for initialTab prop * refactor: tab glider animation * task: update code documentation --------- Co-authored-by: tinuola <[email protected]> * chore(release): set `package.json` to 3.19.0 [skip ci] # [3.19.0](v3.18.0...v3.19.0) (2024-09-17) ### Features * APPS-2943 Add initialTab setting option to TabToggle ([#611](#611)) ([aadedac](aadedac)) * feat: APPS-2945 FTVA Variation of SectionTeaserList (#613) * add separated ftva style files * remove border bottom just for FTVA * make /plan-your-visit the default URL for the Plan Your Visit button in the BlockInfo component * uAdd a SectionWrapper story for TabList component that uses SectionTeaserList * fixes * fixes * section-header * linting * fix past events and csectionteasercard spacing * fix gap * revert default/_section-teaser-card.scss * update changes to blockCardThreeColumn * default styles for section-teaser-list * default styles for section-teaser-list * delete commented out code * move styling to wrapper * update vertical cards * fix syntax * chore(release): set `package.json` to 3.20.0 [skip ci] # [3.20.0](v3.19.0...v3.20.0) (2024-09-20) ### Features * APPS-2945 FTVA Variation of SectionTeaserList ([#613](#613)) ([29e04f0](29e04f0)) * feat: APPS-2946 Create Two Column Layout component (#614) * feat: begin sidebar structure, start drawio docs * feat: more progress side * feat: progress on 2col, stories * chore: finish stories, tests * chore: cleanup, documentation * fix: double padding * fix: inconsistent spacing when card-meta is above sidebar --------- Co-authored-by: Jess Divers <[email protected]> * chore(release): set `package.json` to 3.21.0 [skip ci] # [3.21.0](v3.20.0...v3.21.0) (2024-09-24) ### Features * APPS-2946 Create Two Column Layout component ([#614](#614)) ([cc5d52d](cc5d52d)) * fix: APPS-2947 Update NavBreadcrumb logic to display route title or prop title (#616) * wip: refactor breadcrumb logic * wip: update breadcrumb stories * task: clean up code * fix: add extra logic for parent breadcrumb icon on mobile * update code documentation * update ref, function naming * fix: update ref name in template * fix: remove collapsed class when group is expanded --------- Co-authored-by: tinuola <[email protected]> Co-authored-by: Parinita Mulak <[email protected]> * chore(release): set `package.json` to 3.21.1 [skip ci] ## [3.21.1](v3.21.0...v3.21.1) (2024-09-24) ### Bug Fixes * APPS-2947 Update NavBreadcrumb logic to display route title or prop title ([#616](#616)) ([cba8af6](cba8af6)) * feat: APPS-2957 Create FTVA Pullquote (#617) * feat: ftva pull-quote * chore: lint * fix: font weight, non italic * fix: bolder bold inside pullquote * fix: font weight * fix: add 12px --------- Co-authored-by: Jess Divers <[email protected]> Co-authored-by: Parinita Mulak <[email protected]> * chore(release): set `package.json` to 3.22.0 [skip ci] # [3.22.0](v3.21.1...v3.22.0) (2024-09-24) ### Features * APPS-2957 Create FTVA Pullquote ([#617](#617)) ([65577e8](65577e8)) * fix: APPS-2982 Remove excess padding values (#620) * fix: remove excess padding values * adjust responsiveness of fix --------- Co-authored-by: tinuola <[email protected]> * chore(release): set `package.json` to 3.22.1 [skip ci] ## [3.22.1](v3.22.0...v3.22.1) (2024-09-25) ### Bug Fixes * APPS-2982 Remove excess padding values ([#620](#620)) ([d895d3c](d895d3c)) * chore: APPS-2962 move styles from page to story (#619) * chore: move styles from page to story * fix: tweak gap for 2 cards --------- Co-authored-by: Jess Divers <[email protected]> Co-authored-by: Tinuola 'Tinu' Awopetu <[email protected]> * feat: Apps-2951 card meta changes for article detail page (#618) * feat: card-meta date-created prop * feat: ftvaArticle styles * fix: linter, tweaks * fix: styles based on UX feedback * fix: add globalstore to story for sharebutton * fix: mistake in story --------- Co-authored-by: Jess Divers <[email protected]> * chore(release): set `package.json` to 3.23.0 [skip ci] # [3.23.0](v3.22.1...v3.23.0) (2024-09-27) ### Features * Apps-2951 card meta changes for article detail page ([#618](#618)) ([ace6bfe](ace6bfe)) * fix: hydration error and undefined errors by adding watchers * fix: lint errors --------- Co-authored-by: Tinuola 'Tinu' Awopetu <[email protected]> Co-authored-by: tinuola <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: JenDiamond <[email protected]> Co-authored-by: Jess <[email protected]> Co-authored-by: Jess Divers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2982
Component Created: TwoColLayoutWStickySideBar.vue
Notes:
Before:
After:
Checklist:
library-website-nuxt dev server