Skip to content

Commit

Permalink
feat: move vue-router back to external and peer dependencies (#547)
Browse files Browse the repository at this point in the history
* feat: posiible fix for esbuild error

* feat: add watcheffect and onmounted to make useroute reactive

* feat: remove vue-router from external vite

* feat: redo vite configuration for component library build

* fix: eslint error

* feat: move router to external and peer dependency
  • Loading branch information
pghorpade authored Jul 3, 2024
1 parent 7d26e08 commit b566b96
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,18 @@
"version": "2.39.0-alpha.99",
"main": "./dist/ucla-library-website-components.umd.cjs",
"module": "./dist/ucla-library-website-components.js",
"style": "./dist/style.css",
"files": [
"dist"
],
"exports": {
".": {
"import": "./dist/ucla-library-website-components.js",
"require": "./dist/ucla-library-website-components.umd.cjs"
},
"./dist/style.css": {
"import": "./dist/style.css",
"require": "./dist/style.css"
}
},
"repository": {
Expand Down Expand Up @@ -86,4 +91,4 @@
"peerDependencies": {
"vue": "^3.4.29"
}
}
}
2 changes: 1 addition & 1 deletion vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default defineConfig({
name: 'ucla-library-website-components',
},
rollupOptions: {
external: ['vue'],
external: ['vue', 'vue-router'],
output: {
// preserveModules: true,
exports: 'named',
Expand Down

2 comments on commit b566b96

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.