feat: APPS-2904 #857
Merged
feat: APPS-2904 #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
|
🚀 Preview deployment available at: Netlify Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2904
The draft previews broke in Nuxt3, first because the layout was broken and then the layout data was missing.
This PR will fix the broken layout , the layout data is still missing in the header , but footer is showing up.
The ticket to work to fix the layoutdata for header is this
To fix this, the component library is updated to address the issues mentioned above in this PR UCLALibrary/ucla-library-website-components#623
Remove the use of winwidth check on the Nuxt client side, instead, we have added useWindowSize composable in the component library from vueuse package.
Future work, create a composable or a component to extract some of the duplicate code in app.vue and default.vue
What is broken right now on test and production:
https://uclalibrary-test.library.ucla.edu/about/programs/testing-program-perviews?preview=true&x-craft-preview=V73wpUkkA2&token=4HH8CzUt8cU-l3rbjVbreA9A4IoHqBgv
Fixed:
https://deploy-preview-857--uclalibrary-test.netlify.app/about/programs/testing-program-perviews?preview=true&x-craft-preview=V73wpUkkA2&token=4HH8CzUt8cU-l3rbjVbreA9A4IoHqBgv