refactor: APPS-2411 Add home page #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake gragphQL queries to craft
Percy ScreenshotsIn order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm. |
pghorpade
changed the title
Merge branch 'APPS-2411' of https://github.com/UCLALibrary/library-website-nuxt into APPS-2411
…escript, disable some rules and remove antfu eslint packages
…nc await in server nitro plugin
…static site and updated the alpha component library version
…o storage in these files to set and get
…e prerender as listing pages are not complete, also finished moving library alert on client side in client plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to APPS-2411
Page/Pages Created/updated:
pages/index.vue
pages/about/reports/index.vue
pages/impact/[year]/[slug].vue
pages/impact/[year]/index.vue
pages/impact/all.vue
Documented here:
Nuxt3 setup commit walk thru 1: https://youtu.be/jgpZEDLEt68?si=Extq7FbD9wiKf8OQ
Nuxt3 setup commit walk thru 2: https://youtu.be/McZd2vCmSAw?si=7bemksB_2yTjw-5i
Notes:
Add flexibleblocks to these pages once added to the vue3 component library
Elastic search is not integrated yet with plugins.
Replaced Apollo GraphQL client with nuxt-graphql-request, this is what we used in nuxt2 and is now nuxt3 compatible.
Using nuxt3 nitro server plugin to fetch global craft data for header and footer data.
Will move global notification alert data to default.vue later so it works on the client side and we will not have to regenerate the static site when editors add alerts to craft
Replaced antfu-eslint to nuxt-eslint-config and its typescript plugin for no-undef errors whenusing nuxt magic autoimports.
Will add typescript in later.
Checklist: