Previous submission file #1016
Open
Previous submission file #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to reminified js |
| @@ -762,7 +762,7 @@ function load_input_file(submissionid, key, input) | |||
| var input_file = $('#download-input-file-' + key); | |||
| input_file.attr('href', url ); | |||
| input_file.css('display', 'block'); | |||
| if(allowed_exts.indexOf(".pdf") >= 0) { | |||
| if(input[key]["filename"].endsWith('.pdf')) { | |||
There was a problem hiding this comment.
You can remove the allowed_ext definition if it is not used anymore.
Apart from this, where is load_input_file() used ?
Comment on lines
+109
to
+113
| if not filename.lower().endswith(".pdf"): | ||
| headers = { | ||
| 'Content-Disposition': f'attachment; filename="{filename}"' | ||
| } | ||
| return Response(response=file_content, content_type=mime_type[0], headers=headers) |
There was a problem hiding this comment.
Why having a difference in behavior if the file is a PDF ? I think the best is to download it as any other file.
There was a problem hiding this comment.
This feature has been asked by the professor using INGInious. When you need to review multiple pdf file it's easier to just display it in the browser than downloading all the pdf files on the professor personnal computer. Since the other type of files cannot be directly shown in the browser using a built in feature, we only display pdf files
nrybowski
force-pushed
the
master
branch
2 times, most recently
from
e53b0e2 to
9a6d192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove file preview if non pdf file.
Replace download button action by downloading the file instead of displaying it in the browser which can lead to some issues (#868)