Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty course ID #1009

Closed
wants to merge 2 commits into from
Closed

Fix empty course ID #1009

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c581ac6
id check
thremilien Aug 20, 2024
b4b97f8
typo
thremilien Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion inginious/frontend/course_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from pymongo import ReturnDocument

from inginious.frontend.log import get_course_logger

from inginious.common.base import id_checker
from inginious.frontend.exceptions import CourseNotFoundException, CourseAlreadyExistsException, TasksetNotFoundException
from inginious.frontend.courses import Course

Expand Down Expand Up @@ -57,6 +57,9 @@ def import_legacy_course(self, database, courseid):
return_document=ReturnDocument.AFTER)

def create_course(self, courseid, descriptor):
if not id_checker(courseid):
raise InvalidNameException("Course with invalid name: " + courseid)

existing_course = self._database.courses.find_one({"_id": courseid})
if existing_course:
raise CourseAlreadyExistsException()
Expand Down
Loading