With new API, refactored Riichi calculations to be a formula #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some quality of life improvements, like utilising lists instead of discrete variables Most importantly, made HandScoreCalculator for hand calculation
TwelveNights
approved these changes
Sep 24, 2018
imports/api/HandScoreCalculator.js
Outdated
| // Check to see if you have to count basic points | ||
| if (points < 5) { | ||
| if (fu === 20 || (points === 1 && fu === 25)) { | ||
| throw TypeError("Invalid points/fu combination"); |
There was a problem hiding this comment.
Maybe we can make our own custom exception for this, since TypeError isn't exactly correct
There was a problem hiding this comment.
You're right, it should be RangeError
imports/api/HandScoreCalculator.js
Outdated
| Constants.WINDS.forEach(w => {winds[w] = 0}); | ||
| let basicPoints; | ||
| let nonDealerPays; | ||
| let dealerPays; |
There was a problem hiding this comment.
You can declare these uninitialized variables on one line
There was a problem hiding this comment.
Yo I copy & pasted your code man, will change.
Changed exception type to RangeError Removed extraneous braces Declared variables in one line where applicable
0spooky2me
force-pushed
the
genericise-japanese-score-calculation
branch
from
2bde6e8 to
99a217e
Compare
Mooters
reviewed
Sep 24, 2018
|
Accidental closure |
Mooters
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quality of life improvements, like utilising lists instead of
discrete variables
Most importantly, made HandScoreCalculator for hand calculation
Involved in issue #65