Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTT measurements are now reported per-robot #3422

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AmyKawa
Copy link

@AmyKawa AmyKawa commented Jan 21, 2025

Please fill out the following before requesting review on this PR

Guarantees robot identification is correct (RobotID is no longer lost when data is forwarded to thunderscope) and not based on assumptions of RobotStatus and RobotStatistic

Added new forward that includes RobotID

Tested in mezz

#3391

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@AmyKawa
Copy link
Author

AmyKawa commented Jan 21, 2025

would like src/software/thunderscope/robot_communication.py line 140 to end to be specifically checked because i'm not sure if this is necessary or not. is there ever a time where the forward only sends one piece of data rather than both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant