Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced instances of boost::bind with std::bind or lambda functions. #3410

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wmostrenko
Copy link
Contributor

Please fill out the following before requesting review on this PR

Description

Replaced instances of boost::bind with std::bind or lambda functions throughout the codebase.

Testing Done

Resolved Issues

Resolves #3299

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@itsarune itsarune requested review from a team, DimitriK24 and someone2060 and removed request for a team November 30, 2024 10:44
Copy link
Contributor

@itsarune itsarune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

Can you delete the lines #include boost/bind.hpp and the @boost//::bind from the BUILD files?
image

Also docs/coroutine_test_examples.cpp still uses boost::bind

Copy link

Copy link
Contributor

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale Inactive pull requests label Dec 31, 2024
@itsarune itsarune removed the Stale Inactive pull requests label Dec 31, 2024
Replaced instances of boost::bind with std::bind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all usages of boost::bind with lambda function or std::bind
2 participants