-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1307, TT-11578] Set chart versions for bitnami database charts #4439
Conversation
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (477bd7f) |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting @komalsukhani
When @buraksekili and @caroltyk have peer reviewed I will merge and release.
477bd7f
to
1e6f5a7
Compare
@komalsukhani for future easier maintenance of this page, why don't we use env var like we use for namespace NAMESPACE? |
@komalsukhani for redis installation, if we specify chart version, should we not set the Redis image tag? Especially we support Redis v7 from 5.3 too.
We might add a note that if user is on < Tyk 5.3, they need to check the Redis version supported by Tyk and use the corresponding Redis helm chart. |
...tyk-self-managed/deployment-lifecycle/installations/kubernetes/tyk-helm-tyk-stack-mongodb.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-charts/tyk-control-plane-chart.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-charts/tyk-control-plane-chart.md
Outdated
Show resolved
Hide resolved
@caroltyk I think we should make note more generic and add it below all the bitnami chart reference. |
@caroltyk Is the PR ok to merge now? |
@dcs3spp Ok to merge. Thanks all! |
…ployment-lifecycle/installations/kubernetes/tyk-helm-tyk-stack-mongodb.md Co-authored-by: Burak Sekili <[email protected]>
180a5ad
to
0d5b63f
Compare
/release to release-5.3 |
Working on it! Note that it can take a few minutes. |
* Set bitnami chart versions (cherry picked from commit fd62656)
@dcs3spp Succesfully merged PR |
/release to release-5.2 |
Working on it! Note that it can take a few minutes. |
* Set bitnami chart versions (cherry picked from commit fd62656)
@dcs3spp Succesfully merged PR |
/release to release-5.1 |
Working on it! Note that it can take a few minutes. |
* Set bitnami chart versions (cherry picked from commit fd62656)
@dcs3spp Succesfully merged PR |
…abase charts (#4439) (#4570) * [TT-11578] Set chart versions for bitnami database charts (#4439) --------- Co-authored-by: Komal Sukhani <[email protected]> Co-authored-by: Simon Pears <[email protected]>
User description
For internal users - Please add a Jira DX PR ticket to the subject!
DX-1307
Preview Link
Description
Set version for bitnami charts.
Screenshots (if appropriate)
Checklist
master
.Type
enhancement, documentation
Description
Changes walkthrough
13 files
tyk-helm-tyk-stack-mongodb.md
Update Redis and MongoDB Helm Commands and Add Compatibility Note
tyk-docs/content/deployment-and-operations/tyk-self-managed/deployment-lifecycle/installations/kubernetes/tyk-helm-tyk-stack-mongodb.md
numbers.
tyk-helm-tyk-stack-postgresql.md
Update Redis and PostgreSQL Helm Commands
tyk-docs/content/deployment-and-operations/tyk-self-managed/deployment-lifecycle/installations/kubernetes/tyk-helm-tyk-stack-postgresql.md
version numbers.
tyk-control-plane-chart.md
Update Helm Commands and Add MongoDB Compatibility Note
tyk-docs/content/product-stack/tyk-charts/tyk-control-plane-chart.md
numbers.
tyk-data-plane-chart.md
Update Redis Helm Command
tyk-docs/content/product-stack/tyk-charts/tyk-data-plane-chart.md
tyk-oss-chart.md
Update Helm Commands and Add MongoDB Compatibility Note
tyk-docs/content/product-stack/tyk-charts/tyk-oss-chart.md
numbers.
tyk-stack-chart.md
Update Helm Commands and Add MongoDB Compatibility Note
tyk-docs/content/product-stack/tyk-charts/tyk-stack-chart.md
numbers.
otel_jaeger_k8s.md
Update Redis Helm Command
tyk-docs/content/product-stack/tyk-gateway/advanced-configurations/distributed-tracing/open-telemetry/otel_jaeger_k8s.md
setup-prometheus-pump.md
Update Redis Helm Command
tyk-docs/content/product-stack/tyk-pump/advanced-configurations/setup-prometheus-pump.md
hybrid-gateways-helm.md
Update Redis Helm Command
tyk-docs/content/tyk-cloud/environments-deployments/hybrid-gateways-helm.md
hybrid-gateways.md
Update Redis Helm Command
tyk-docs/content/tyk-cloud/environments-deployments/hybrid-gateways.md
ce-helm-chart-new.md
Update Redis Helm Command
tyk-docs/content/tyk-oss/ce-helm-chart-new.md
ce-helm-chart.md
Update Redis Helm Command
tyk-docs/content/tyk-oss/ce-helm-chart.md
tyk-helm-chart.md
Update Helm Commands and Add MongoDB Compatibility Note
tyk-docs/content/tyk-self-managed/tyk-helm-chart.md
specific version numbers.