-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1261] Update partitioned-policies.md with note about ACL #4411
Conversation
When partitioned policies are assigned to a token, at least of these policies needs to enforce ACL - this part was missing.
PR Description updated to latest commit (4094369) |
PR Review
Code feedback:✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
tyk-docs/content/basic-config-and-security/security/security-policies/partitioned-policies.md
Outdated
Show resolved
Hide resolved
Hi @behcio thanks for contributing the fix. Would you be able to add a preview link and a label for which release this targets or now label if it is intended for the current release |
@dcs3spp Preview link added. As for labels... which label should I add if it's something that applies all the way back to 3.0? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @behcio for submitting updated content fix. PR LGTM, I have made some minor suggestions and then think we can release
tyk-docs/content/basic-config-and-security/security/security-policies/partitioned-policies.md
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/security-policies/partitioned-policies.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/basic-config-and-security/security/security-policies/partitioned-policies.md
Outdated
Show resolved
Hide resolved
…olicies/partitioned-policies.md
/release to release-5.3 |
Working on it! Note that it can take a few minutes. |
Update partitioned-policies.md with note about ACL (cherry picked from commit e0b6a14)
@dcs3spp Succesfully merged PR |
/release to release-5.2 |
Working on it! Note that it can take a few minutes. |
Working on it! Note that it can take a few minutes. |
Update partitioned-policies.md with note about ACL (cherry picked from commit e0b6a14)
@dcs3spp Succesfully merged PR |
/release to release-4 |
Working on it! Note that it can take a few minutes. |
Update partitioned-policies.md with note about ACL (cherry picked from commit e0b6a14)
@dcs3spp Succesfully merged PR |
/release to release-3.2 |
Working on it! Note that it can take a few minutes. |
Update partitioned-policies.md with note about ACL (cherry picked from commit e0b6a14)
@dcs3spp Succesfully merged PR |
… note about ACL (#4411) (#4420) [DX-1261] Update partitioned-policies.md with note about ACL (#4411) Co-authored-by: behcio <[email protected]>
/release to release-3.1 |
Working on it! Note that it can take a few minutes. |
Update partitioned-policies.md with note about ACL (cherry picked from commit e0b6a14)
@dcs3spp Succesfully merged PR |
/release to release-3-lts |
Working on it! Note that it can take a few minutes. |
Update partitioned-policies.md with note about ACL (cherry picked from commit e0b6a14)
@dcs3spp Succesfully merged PR |
User description
When partitioned policies are assigned to a token, at least of these policies needs to enforce ACL - this part was missing.
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
https://deploy-preview-4411--tyk-docs.netlify.app/docs/nightly/basic-config-and-security/security/security-policies/partitioned-policies/#example-use-case
Description
Screenshots (if appropriate)
Checklist
master
.Type
documentation
Description
Changes walkthrough
partitioned-policies.md
Update ACL Requirement Note for Partitioned Policies
tyk-docs/content/basic-config-and-security/security/security-policies/partitioned-policies.md
assigned to a key needs to enforce ACL.