-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1245] Tyk OAS launch notices and restructuring for 5.3 #4382
Conversation
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Description updated to latest commit (d0f1b3f) |
PR Review
Code feedback:✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyo-tyk PR LGTM, I have made minor suggestions and commented reagrding if Tyk GW automatically migrates Tyk OAS API Definitions to new format or if this is just Dashboard
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/using-oas-definitions/oas-reference.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/plugins/supported-languages/rich-plugins/python/python.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/tyk-cloud/getting-started-tyk-cloud/first-api.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/tyk-cloud/getting-started-tyk-cloud/first-api.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/getting-started/key-concepts/high-level-concepts.md
Outdated
Show resolved
Hide resolved
cb3d14b
to
5ffb358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andyo-tyk PR LGTM and thanks for updating PR from suggestions. I have had a final look through the PR.
The menu items have been renamed in Product Stack->Tyk Gateway (Open Source) -> Key Concepts->Tyk OAS & Tyk Classic.
Do the submenus relate to API Definitions or APIs or both? Should they be renamed as Tyk OAS API Definitions & Tyk Classic API Definitions or we could create a virtual subfolder in key concepts, something like?
Tyk API Definitions
|
|——What Is An API Definition?
|——Tyk OAS???
|——Tyk Classic API???
The key concepts overview page is a small page and for this reason has been hidden via the menu.yaml in the PR.
Maybe it should be removed and create an alias to either:
- Product Stack -> Tyk Gateway (Open Source) -> Overview
- Product Stack -> Tyk Gateway (Open Source) -> Key Concepts -> What is an API Definition?
or.... - Keep visible and expand key cooncepts overview content at a later date
I'm trying to work as much as possible within the docs structure provided by the DX team as I don't think it's right for me to propose wholesale change in this PR. I've moved pages where they are in the wrong part of the docs structure, but otherwise trying to work with what's already there. As it happens, the (existing) content of the The content of the Perhaps rename these to:
(though for the latter, I think the docs need some TLC - out of scope for the Tyk OAS work I've been doing) |
5ffb358
to
6026561
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyo-tyk I've approved PR and renamed the menu items Tyk OAS Concepts and Tyk Classic Concepts and will merge and release.
/release to release-5.3 |
Working on it! Note that it can take a few minutes. |
* fix build error with link to release notes for 5.3 * rename Tyk OAS to Tyk OAS Concepts. Same for Tyk Classic * Keep key concepts menu item displayed --------- Co-authored-by: Simon Pears <[email protected]> (cherry picked from commit 0552f70)
@dcs3spp Succesfully merged PR |
…uring for 5.3 (#4382) [DX-1245] Tyk OAS launch notices and restructuring for 5.3 (#4382) * fix build error with link to release notes for 5.3 * rename Tyk OAS to Tyk OAS Concepts. Same for Tyk Classic * Keep key concepts menu item displayed --------- Co-authored-by: Simon Pears <[email protected]>
User description
For internal users - Please add a Jira DX PR ticket to the subject!
Preview Link
https://deploy-preview-4382--tyk-docs.netlify.app/docs/getting-started/
Description
This seems quite big, but is basically a reordering of pages in the Tyk Gateway and Tyk Dashboard docs, removing some that are no longer required and applying changes for Tyk OAS maturity to improve usability of the docs. Unfortunately a lot of this had to happen together. No technical content changes.
This PR replaces #4335
Type
enhancement, documentation
Description
Changes walkthrough
1 files
menu.yaml
Updated menu structure for OAS and Tyk Classic API documentation
tyk-docs/data/menu.yaml
11 files
transform-traffic.md
Added overview and list of request/response middleware
tyk-docs/content/advanced-configuration/transform-traffic.md
session-meta-data.md
Updated session metadata documentation
tyk-docs/content/getting-started/key-concepts/session-meta-data.md
openapi-specification.md
Introduced Tyk OAS and its API Definition structure
tyk-docs/content/getting-started/key-concepts/openapi-specification.md
oas-reference.md
Updated Tyk OAS API feature implementation status
tyk-docs/content/getting-started/using-oas-definitions/oas-reference.md
oas-glossary.md
Updated glossary for Tyk OAS and Classic API definitions
tyk-docs/content/getting-started/using-oas-definitions/oas-glossary.md
tyk-gateway-features-include.md
Updated Tyk Gateway feature list and description
tyk-docs/content/shared/tyk-gateway-features-include.md
basic-config-and-security.md
Added section on logging API traffic
tyk-docs/content/basic-config-and-security.md
first-api.md
Added warning about Tyk OAS APIs feature maturity
tyk-docs/content/tyk-cloud/getting-started-tyk-cloud/first-api.md
compatibility.
mock-response-tyk-classic.md
Added endpoint parsing explanation for mock responses
tyk-docs/content/product-stack/tyk-gateway/middleware/mock-response-tyk-classic.md
python.md
Updated note on Python support in Tyk Gateway Docker images
tyk-docs/content/plugins/supported-languages/rich-plugins/python/python.md
oas-versioning.md
Updated next step link for OAS versioning
tyk-docs/content/getting-started/key-concepts/oas-versioning.md