-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mutex to functions that use ForEachMaster method #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mativm02
changed the title
restructuring FlushAll method in tests
Adding mutex to functions that use ForEachMaster method
Jan 11, 2024
mativm02
requested review from
sredxny and
tbuchaillot
and removed request for
sredxny
January 23, 2024 16:39
tbuchaillot
approved these changes
Jan 24, 2024
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 3 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ForEachMaster is a Redis' method that concurrently iterates over each master of the cluster instance. We weren't using a mutex, so this caused a race condition and the final results were randomly incorrect.
Also, I deleted the return of cursor in GetKeysWithOpts since we're not using it nowhere and it causes confusion when the instance is a cluster (since each master node could return a different cursor).
New
GetKeysWithOpts
can be used in the following way:Note that it's important to use the returned cursor map on each new
GetKeysWithOpts
call.Related Issue
Motivation and Context
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.go mod tidy && go mod vendor
gofmt -s -w .
go vet ./...