-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change script engine to use Sol2 instead of LuaBridge #3
base: master
Are you sure you want to change the base?
Conversation
…unning out of memory despite the system having more than sufficient free memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive changes! I'd much prefer if sol.hpp could go in GameLibs though because it's just a dependency, not original code. We should probably change from using a GameLibs.zip to an external libs folder of some kind (next to the src folder)
@@ -641,3 +641,33 @@ void BBox::serialize(FileInterface* file) { | |||
file->property("mass", mass); | |||
} | |||
} | |||
|
|||
//These functions are not in the script.cpp file since they drastically increase compile time and memory usage due to heavy template usage. | |||
void Script::exposeBBox() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for a first pass but if these expose functions could be members of their respective classes (ie BBox::exposeToScript() instead of Script::exposeBBox()) it would be way better.
@@ -73,23 +75,43 @@ class Button { | |||
void setStyle(const style_t _style) { style = _style; } | |||
void setPressed(const bool _pressed) { reallyPressed = _pressed; } | |||
|
|||
template<typename T> | |||
void addParam(T param) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way better, kudos.
We can do that, I was honestly just too lazy to add it to CMake ;P |
Signed-off-by: SheridanR <[email protected]>
Conflicts: src/Entity.cpp vs.2017/spacepunk/spacepunk.vcxproj
Signed-off-by: SheridanR <[email protected]>
d0659e9
to
3d3cfe6
Compare
No description provided.