Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompatHelper.yml #269

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Update CompatHelper.yml #269

merged 1 commit into from
Aug 19, 2021

Conversation

rikhuijzer
Copy link
Contributor

@rikhuijzer rikhuijzer commented Aug 19, 2021

CompatHelper is opening too many PRs due to some internal rewrites on their side. Let's disable it for a few months and try to get the already open PRs done. We don't need extra PRs for now.

See also: JuliaRegistries/CompatHelper.jl#378 or other issues at CompatHelper.

@rikhuijzer rikhuijzer merged commit 963ea39 into master Aug 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the disable-compathelper branch August 19, 2021 07:37
@devmotion
Copy link
Member

An alternative (better?) approach would be to use CompatHelper 2 if CompstHelper 3 causes problems.

@devmotion
Copy link
Member

Just a heads up: I'm not completely sure what's the common practice in TuringTutorials but in most other Turing repos we follow ColPrac which requires approval of another contributor with merge rights before a PR is merged.

@rikhuijzer
Copy link
Contributor Author

Yes, you're right. Usually, I do wait for approval, but this morning I got very annoyed by the CompatHelper PRs because I've worked hours and hours to get rid of those PRs.

Next time, I'll wait for review again.

@yebai
Copy link
Member

yebai commented Aug 19, 2021

Yes, you're right. Usually, I do wait for approval, but this morning I got very annoyed by the CompatHelper PRs because I've worked hours and hours to get rid of those PRs.

I've closed these Compat PRs in batch. We can re-enable CompatHelper (if needed).

@rikhuijzer
Copy link
Contributor Author

I've closed these Compat PRs in batch. We can re-enable CompatHelper (if needed).

As long as the compat entries aren't updated, this would re-open them again next week if I'm not mistaken.

The only real solution here is to update the compat entries, which I'm working on (for example, #248 and #249). My idea was to keep CompatHelper disabled for a bit and first fix the existing backlog of CompatHelper PRs.

@rikhuijzer
Copy link
Contributor Author

The progress of adding assertions can be tracked here: #218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants