-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monorepo squashed commit #59
base: monorepo
Are you sure you want to change the base?
Conversation
Replicating Callum's comment from other PR here:
|
@chmac I'd like to find something that works on more than just my machine before I write up a Readme. The PR also does some config for making a device build, because that needs to work with the monorepo. Our current setup doesn't allow for building because the cross-linked package cannot be found, so I want to make sure the monorepo lets the user build things. This is not meant to break the Expo Go flow. It continues to work on my machine with this branch. I do have to specify whether I want to use Expo Go or device build though both in the app and on the CLI when launching, but imagine that can be handled by passing a parameter as well. Can you say what's broken about Expo Go for you? The |
There's a mistake with the branches here, you're merging into the |
@shuesken wanted me to test:
|
I get this error:
I'm not sure what the cause is. If I use |
I get the following for iOS:
|
The log file it mentions contains:
|
That's all I can manage today. Looks like it won't build for iOS. But why I'm not sure. |
No description provided.