Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add dependabot #11

wants to merge 1 commit into from

Conversation

oriontvv
Copy link

This PR adds dependabot config

@oriontvv oriontvv requested a review from a team as a code owner February 10, 2024 11:16
Copy link
Member

@suryapandian suryapandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🚀

Copy link
Member

@eopb eopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @oriontvv

I'm happy to merge just the GitHub actions section. I don't think the other two will be useful for us.

Comment on lines +3 to +7
- package-ecosystem: "cargo"
directory: "/"
schedule:
interval: "monthly"
open-pull-requests-limit: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up reverting your PR on reqwest-middleware because the cargo upgrades were far too noisy. Dependabot was opening PRs for minor upgrades which is unhelpful since, for libraries, we aim closer to the minimum compatible version, rather than the latest one. For major version upgrades, I prefer to gauge demand by waiting for our users to open PRs/issues.

Suggested change
- package-ecosystem: "cargo"
directory: "/"
schedule:
interval: "monthly"
open-pull-requests-limit: 10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for reply

Comment on lines +8 to +11
- package-ecosystem: "docker"
directory: "/"
schedule:
interval: "monthly"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this repo contains any dockerfiles

Suggested change
- package-ecosystem: "docker"
directory: "/"
schedule:
interval: "monthly"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants