Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow owners to view public networks #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow owners to view public networks #80

wants to merge 1 commit into from

Conversation

Smithx10
Copy link

@Smithx10 Smithx10 commented Mar 29, 2021 •
edited
Loading

Addresses #77

@danmcd danmcd mentioned this pull request Apr 30, 2021
Open
danmcd
danmcd reviewed Apr 30, 2021
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note your testing in #77. I might open a TRITON ticket along with it. I'm pinging @bahamat too just in case he has something to say.

@danmcd
Copy link
Contributor

danmcd commented May 21, 2021

Please run "make check" on this and correct any errors it finds, please.

bahamat
bahamat requested changes May 21, 2021
View reviewed changes
lib/endpoints/networks.js
}
});
}
if (account != null && net.owner_uuids != null && net.owner_uuids.indexOf(account) > -1) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to make check issues, this code doesn't work.

[2021-05-21T18:18:53.220Z] ERROR: cloudapi/80319 on 882de077-91f3-4f27-9a24-67d0efe0b8e5: unexpected error (req_id=41d2d897-ae7c-4227-bbcf-27b55247068c)
    TypeError: Cannot read property 'indexOf' of undefined
        at translateNetwork (/opt/smartdc/cloudapi/lib/endpoints/networks.js:188:24)
        at /opt/smartdc/cloudapi/lib/endpoints/networks.js:283:16
        at Array.map (native)
        at Server.listNetworks (/opt/smartdc/cloudapi/lib/endpoints/networks.js:282:8)
        at next (/opt/smartdc/cloudapi/node_modules/restify/lib/server.js:912:30)
        at f (/opt/smartdc/cloudapi/node_modules/once/once.js:25:25)
        at Server.rateLimit (/opt/smartdc/cloudapi/node_modules/restify/lib/plugins/throttle.js:294:17)
        at next (/opt/smartdc/cloudapi/node_modules/restify/lib/server.js:912:30)
        at f (/opt/smartdc/cloudapi/node_modules/once/once.js:25:25)
        at Server.saveContext (/opt/smartdc/cloudapi/lib/app.js:499:28)

@bahamat bahamat self-assigned this May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd left review comments

@bahamat bahamat bahamat requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@bahamat bahamat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smithx10 @danmcd @bahamat