Add server logging for CKEditor state changes #941
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pano9000
reviewed
Jan 14, 2025
| @@ -165,7 +165,7 @@ export default class EditableTextTypeWidget extends AbstractTextTypeWidget { | |||
| return; | |||
| } | |||
|
|
|||
| console.log(`CKEditor changed to ${currentState}`); | |||
| logInfo(`CKEditor changed to ${currentState}`) | |||
|
|
|||
| this.watchdog.crashes.forEach(crashInfo => console.log(crashInfo)); | |||
There was a problem hiding this comment.
Without having an idea about the internals of CKEdiitor, but would it make sense to also send the "crashInfo" to the server logs?
There was a problem hiding this comment.
It's a good idea. Unfortunately I think many of these crashes might have confusing traces of minimized code, but given the importance of CKEditor, it's worth it to have as much information as possible.
These crashes are rare.
I added a string log to send to the backend, and kept the console.log for easier viewing in the console.
|
Just rebased on develop 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #454 and #831, it would be useful to have logging about the state of the CKEditor in the server logs. This could help give us better understanding of frontend crashes, and other weird frontend state.