Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing a map note type #1017

Merged
merged 43 commits into from
Jan 22, 2025
Merged

Introducing a map note type #1017

merged 43 commits into from
Jan 22, 2025

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented Jan 20, 2025 •
edited
Loading

This is the first version of the map view, which displays a geographical map using Leaflet and allows the user to add pins/markers on the map, using child notes.

image

@eliandoran
feat(geomap): create geomap note type
e1952fe
@eliandoran
feat(geomap): load leaflet
94a0403
@eliandoran
feat(geomap): add basic layer
eca3955
@eliandoran
refactor(geomap): skip module loader for JS
2b8ee31
@eliandoran
feat(mindmap): save view center coordinates
5cefd4f
@eliandoran
feat(geomap): restore view coordinates
f66f437
@eliandoran
feat(geomap): save & restore zoom
4d5e04f
@eliandoran
feat(geomap): add floating button section
f803b9f
@eliandoran
feat(geomap): add prompt for creating child note
2582924
@eliandoran
feat(geomap): set location after creating a note
a3f257f
@eliandoran
feat(geomap): load markers at startup
f76b454
@eliandoran
feat(geomap): reload markers after adding a new note
986a1c2
@eliandoran
fix(geomap): multiple clicks creating multiple markers
ef5b2d6
@eliandoran
feat(geomap): adjust cursor when adding new note
fed0598
@eliandoran
feat(geomap): allow dragging
3281bb8
@eliandoran
fix(geomap): duplicate markers
04367de
@eliandoran
feat(geomap): enable autopan for dragging markers
b2a5f06
@eliandoran
feat(geomap): setup marker based on note icon
087d479
@eliandoran
fix(geomap): pixel perfect marker positioning
016a9e4
@eliandoran
style(geomap): improve alignment for marker icon
1be3492
@eliandoran
feat(geomap): add shadow to marker
08722d5
@eliandoran
feat(geomap): add labels to markers
6b906a9
@eliandoran
feat(geomap): set custom icon for notes created from within the map
259dcdb
@eliandoran
feat(geomap): invert note creation workflow
d1aa0e5
@eliandoran
feat(geomap): dismiss creation if dialog is dismissed
c2cb07e
@eliandoran
feat(geomap): dismiss adding with escape
be4ee4c
@eliandoran
refactor(geomap): simplify changing state
dc7dd51
@eliandoran
chore(geomap): change attribute to geolocation
b813b10
@eliandoran
feat(geomap): use persistent notification
31491b9
@eliandoran
fix(geomap): dismissing add with any key
6555325
@eliandoran eliandoran marked this pull request as ready for review January 22, 2025 20:51
@eliandoran eliandoran merged commit 16b5eef into develop Jan 22, 2025
5 checks passed
@eliandoran eliandoran deleted the feature/map_note_type branch January 22, 2025 21:34
@eliandoran eliandoran changed the title Map note type Introducing a map note type Jan 22, 2025
@maphew
Copy link

maphew commented Jan 28, 2025

oooh, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliandoran @maphew