chore(ci): using signing params instead of hook

TriliumNext · Jan 19, 2025 · 1a00e40 · 1a00e40
1 parent 25a8b77
commit 1a00e40
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.github/actions/build-electron/action.yml b/.github/actions/build-electron/action.yml
@@ -25,6 +25,9 @@ runs:
     - name: Run electron-forge
       shell: cmd
       run: npm run make-electron -- --arch=${{ inputs.arch }}
+      env:
+        WINDOWS_SIGNTOOL_PATH: "C:\\ev_signer_trilium\\ev_signer_trilium.exe"
+        WINDOWS_SIGN_WITH_PARAMS: --executable
     - uses: actions/upload-artifact@v4
       with:
         name: Artifacts

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -38,6 +38,9 @@ jobs:
           os: ${{ matrix.os.name }}
           arch: ${{ matrix.arch }}
           extension: ${{ matrix.os.extension }}
+        env:
+          WINDOWS_SIGNTOOL_PATH: "C:\\ev_signer_trilium\\ev_signer_trilium.exe"
+          WINDOWS_SIGN_WITH_PARAMS: --executable
       - name: Publish artifacts
         uses: actions/upload-artifact@v4
         with:

diff --git a/forge.config.cjs b/forge.config.cjs
@@ -10,6 +10,8 @@ module.exports = {
         overwrite: true,
         asar: true,
         icon: "./images/app-icons/icon",
+        signToolPath: "C:\\ev_signer_trilium\\ev_signer_trilium.exe",
+        signWithParams: "--executable",
         extraResource: [
             // Moved to root
             ...getExtraResourcesForPlatform(),
@@ -63,10 +65,7 @@ module.exports = {
             config: {
                 iconUrl: "https://raw.githubusercontent.com/TriliumNext/Notes/develop/images/app-icons/icon.ico",
                 setupIcon: "./images/app-icons/icon.ico",
-                loadingGif: "./images/app-icons/win/setup-banner.gif",
-                windowsSign: {
-                    hookModulePath: "./bin/sign-windows.js"
-                }
+                loadingGif: "./images/app-icons/win/setup-banner.gif"
             }
         },
         {