feat(rest): Created rest package #200

TriPSs · 2023-11-09T12:38:52Z

TODO

Maybe create separate package with the shared code between rest and graphql packages (Like the interceptors)?

nx-cloud · 2023-11-09T12:40:56Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 49cd3a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

codecov-commenter · 2023-11-09T12:44:09Z

Codecov Report

Attention: 192 lines in your changes are missing coverage. Please review.

Comparison is base (c11da0c) 86.28% compared to head (5bd8ccb) 79.06%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
...ages/query-rest/src/providers/resolver.provider.ts	48.71%	14 Missing and 6 partials ⚠️
...kages/query-rest/src/decorators/field.decorator.ts	55.55%	5 Missing and 11 partials ⚠️
...s/query-rest/src/decorators/hook-args.decorator.ts	51.72%	12 Missing and 2 partials ⚠️
...-rest/src/decorators/filterable-field.decorator.ts	56.00%	7 Missing and 4 partials ⚠️
...est/src/decorators/controller-methods.decorator.ts	75.60%	4 Missing and 6 partials ⚠️
...es/query-rest/src/interceptors/hook.interceptor.ts	41.17%	9 Missing and 1 partial ⚠️
...ges/query-rest/src/auth/default-crud.authorizer.ts	63.15%	4 Missing and 3 partials ⚠️
...es/query-rest/src/connection/offset/pager/pager.ts	75.00%	3 Missing and 4 partials ⚠️
...kages/query-rest/src/decorators/decorator.utils.ts	12.50%	5 Missing and 2 partials ⚠️
...ckages/query-rest/src/resolvers/update.resolver.ts	76.66%	5 Missing and 2 partials ⚠️
... and 31 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   86.28%   79.06%   -7.22%     
==========================================
  Files         688      767      +79     
  Lines        9761    10623     +862     
  Branches      862      955      +93     
==========================================
- Hits         8422     8399      -23     
- Misses        619     1401     +782     
- Partials      720      823     +103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/query-rest/src/decorators/filterable-field.decorator.ts

# Conflicts: # examples/project.json # package.json # yarn.lock

nx-cloud · 2024-02-08T13:35:11Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2353ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx run-many --target=e2e --all`
`nx run-many --target=lint --all`
`nx run-many --target=build --all`

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

# Conflicts: # package.json # yarn.lock

…l hooks

…rray

…er in `@Field` decorator

# Conflicts: # yarn.lock

…to use it - Added `FindOneArgsType` for standardizing ID parameter handling. - Updated delete, update, and read resolvers to use `FindOneArgsType`. - Introduced new `id-field.decorator` for marking ID fields. - Removed redundant `BadRequestException` in read resolver.

…ecorator

…clude "Args" suffix

# Conflicts: # yarn.lock

…piSchema decorator

- Correct `FindOneArgsType` parameter in `read.resolver.ts` - Enhance `field.decorator.ts` to properly retrieve metadata - Add `IsNumber` and `IsString` validators for specific types - Improve handling of array options and validation

kasir-barati · 2025-01-26T14:01:32Z

@TriPSs What's going on in this PR? Kinda curious as to on what you're working in this branch. The name kinda does not ring a bell. I mean what do you mean by "rest"?

TriPSs · 2025-01-26T15:56:28Z

@TriPSs What's going on in this PR? Kinda curious as to on what you're working in this branch. The name kinda does not ring a bell. I mean what do you mean by "rest"?

The current packages are focused on building a GraphQL API, this will add a package to create/support REST (Get, Post, Put, Delete) API (More traditional), I'm currently still building this out in inside a other project who will almost go live, so once that is done i'm back porting it here and will implement some tests so it can be released.

kasir-barati · 2025-01-26T17:21:10Z

OK, so basically it will be a new package next to the others we have already. But I am worried if this will introduce extra functionality which just might complicate the source code unnecessarily. Will skim through in the next week.

TriPSs · 2025-01-26T17:24:46Z

Well it's something I wanted/needed so i'm still going to add it, it's open for others to then also use if they don't want GraphQL.

Also since it's completely islolated in it's own package (just like GraphQL is) and uses the other services (just like the GraphQL one does) I do not see how this complicates the code base, as people only tend to look at the things they need/use (if they look at all).

kasir-barati · 2025-01-26T17:27:44Z

@TriPSs OK if this has been isolated from other packages I am quite eager to see how it's been implemented. Kudos @TriPSs 💮.

TriPSs · 2025-01-26T17:32:39Z

Well the idea is to be exactly like the GraphQL one (but with minor differences as not everything in GraphQL is available in REST), with full swagger/open api support so frontend types/libs can still be automatically generated :)

Once the internal version is live I will update this PR with the latest version, improve some naming, cleanup, add tests and merge it in for others to use.

feat(rest): Created rest package

dbfca70

refactor(rest): Linting

49cd3a4

TriPSs commented Nov 10, 2023

View reviewed changes

packages/query-rest/src/decorators/filterable-field.decorator.ts Outdated Show resolved Hide resolved

TriPSs added 12 commits December 1, 2023 09:27

refactor(rest): Improved @Field decorator

488a39c

refactor(rest): Improved @Field decorator

24a6196

refactor(rest): Improved @Field and @FilterableField decorators

8178f02

ci: Added dependabot.yml and stale.yml

4529d18

refactor(rest): Improved @Field decorator

f16f6c6

refactor(rest): Updated lint

612a43a

test(rest): Added basic test case for one endpoint

0d0b9f5

refactor: Lint examples

221ca7b

refactor(rest): Improved @Field decorator

f8daf99

Merge branch 'master' into feature/rest

064a447

# Conflicts: # examples/project.json # package.json # yarn.lock

chore: Merge dev

49b16fd

refactor(rest): Improved controller methods swagger implementation

5bd8ccb

TriPSs added 11 commits June 14, 2024 11:51

Merge branch 'refs/heads/master' into feature/rest

9636397

# Conflicts: # package.json # yarn.lock

chore: Merge master

dc97f26

fix(query-rest): Fixed paging not working when there are no additiona…

887910b

…l hooks

fix(query-rest): Added IsArray validation to @Field if field is a…

3eb2454

…rray

feat(query-rest): Added forceArray option to to @Field decorator

45932c9

fix(query-rest): Prevent non-valid options from being passed to swagg…

85393ad

…er in `@Field` decorator

Merge branch 'refs/heads/improvements' into feature/rest

d4d4553

# Conflicts: # yarn.lock

chore: Updated lockfile

7245c19

feat(rest): Added support for @FilterableField

ad5c987

fix(rest): Fixed filterable fields always required

f1ef57f

fix(rest): Fixed forceArray and skipIsEnum not working for @Field

67a9196

TriPSs marked this pull request as draft July 26, 2024 12:45

TriPSs added 11 commits August 21, 2024 17:00

fix(query-rest): Add min and max validation to field decorator

b70eacd

fix(query-rest): Read resolver not respecting disabled opt

87b7c05

feat(query-rest): Add idOnly option to IDFieldOptions in id-field.d…

4111575

…ecorator

fix(query-rest): Add name option to Expose decorator in field decorator

7d46be2

refactor(query-rest): Update unique name values for DTO classes to in…

ee816fb

…clude "Args" suffix

Merge branch 'master' into feature/rest

465589a

# Conflicts: # yarn.lock

chore: Updated lockfile

84a6b2e

refactor(query-rest): Simplify usage of DTOClass parameters and add A…

d3cfb9f

…piSchema decorator

feat(query-rest): Add IsDate validation to field decorator

e2353ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rest): Created rest package #200

feat(rest): Created rest package #200

TriPSs commented Nov 9, 2023 •

edited

Loading

nx-cloud bot commented Nov 9, 2023 •

edited

Loading

codecov-commenter commented Nov 9, 2023 •

edited

Loading

nx-cloud bot commented Feb 8, 2024 •

edited

Loading

kasir-barati commented Jan 26, 2025

TriPSs commented Jan 26, 2025

kasir-barati commented Jan 26, 2025

TriPSs commented Jan 26, 2025

kasir-barati commented Jan 26, 2025

TriPSs commented Jan 26, 2025

feat(rest): Created rest package #200

Are you sure you want to change the base?

feat(rest): Created rest package #200

Conversation

TriPSs commented Nov 9, 2023 • edited Loading

nx-cloud bot commented Nov 9, 2023 • edited Loading

☁️ Nx Cloud Report

codecov-commenter commented Nov 9, 2023 • edited Loading

Codecov Report

nx-cloud bot commented Feb 8, 2024 • edited Loading

☁️ Nx Cloud Report

kasir-barati commented Jan 26, 2025

TriPSs commented Jan 26, 2025

kasir-barati commented Jan 26, 2025

TriPSs commented Jan 26, 2025

kasir-barati commented Jan 26, 2025

TriPSs commented Jan 26, 2025

TriPSs commented Nov 9, 2023 •

edited

Loading

nx-cloud bot commented Nov 9, 2023 •

edited

Loading

codecov-commenter commented Nov 9, 2023 •

edited

Loading

nx-cloud bot commented Feb 8, 2024 •

edited

Loading