Implement URL normalization in cdash_analyze_and_report.py (#577) #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
urllib.parse.quote
from the standard library. Note: I did add a python2 fallback, which I believe should work, but I have not tested, nor do I know if that's a target at this time.*_project_name_ampersand
). Previously this was only applied ingetCDashQueryTestsQueryUrl
, but I felt it was best to be consistent.getCDashQueryTestsBrowserUrl
to construct the query URLs. The quote function cannot be applied to the entire URL (which would be vastly more convenient) because, from the docs:That is, if you apply it to the full URL it will escape things you don't want it to (e.g., the '&' in the php queries). Since we are manually constructing these, it is simple enough to apply.