Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offline login persistence #275

Merged
merged 7 commits into from
Dec 20, 2024
Merged

feat: offline login persistence #275

merged 7 commits into from
Dec 20, 2024

Conversation

loggerz
Copy link
Contributor

@loggerz loggerz commented Dec 19, 2024

Closes #233

@loggerz loggerz self-assigned this Dec 19, 2024
@loggerz loggerz marked this pull request as ready for review December 20, 2024 05:52
ArthurChalard
ArthurChalard requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ArthurChalard ArthurChalard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I almost forgot that we had to manage this case. The helper is also a good idea as it separates the code

app/src/main/java/com/github/se/travelpouch/model/authentication/NetworkConnectivityHelper.kt Outdated Show resolved Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/authentication/SignIn.kt Show resolved Hide resolved
ArthurChalard
ArthurChalard approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ArthurChalard ArthurChalard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, the change is perfect for me

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
75.0% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ArthurChalard ArthurChalard merged commit 2655858 into main Dec 20, 2024
2 of 3 checks passed
@ArthurChalard ArthurChalard deleted the feature/signin-persistence-offline branch December 20, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurChalard ArthurChalard ArthurChalard approved these changes

Assignees

@loggerz loggerz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle the sign-in persistence edge-cases
2 participants
@loggerz @ArthurChalard