feat: add travel mode in ActivitiesMapScreen #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanPetersTM
requested changes
Dec 14, 2024
There was a problem hiding this comment.
Excellent PR and code, as always from you! There are a couple minor things to changes like a small bug but overall the code is clean and readable and the feature works.
PS: I just discovered that the code from your previous PR handles perfectly the case where the distance between two activities is very big!
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreen.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreenTest.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/github/se/travelpouch/ui/dashboard/map/ActivitiesMapScreenTest.kt
Show resolved
Hide resolved
|
StefanPetersTM
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the possibility of displaying paths (GPS and activities) with different modes of transport (walking, driving and cycling).
It includes :
ActivitiesScreenMap: 4 button to choose the travel mode for the path between activities.Activity Bottom Sheet: 1 button to show the gps pathGPS Bottom Sheet: 4 button to choose the travel mode for the path between gps and activity.