Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test for activity #251

Merged
merged 23 commits into from
Dec 13, 2024
Merged

E2E test for activity #251

merged 23 commits into from
Dec 13, 2024

Conversation

RemIsMyWaifuu
Copy link
Contributor

@RemIsMyWaifuu RemIsMyWaifuu commented Dec 11, 2024 •
edited
Loading

Copied from #253:

Description:
The project requires 4 E2E tests for M3. Thus this test should be a fine addition by testing activity creation as well as activity editing.
Acceptance Criteria:

  • The test creates a new activity without the activity being seeded already
  • The test edits the same activity changing atleast 1 field.
  • The test checks that the entries are correct before and after editing.

@RemIsMyWaifuu
test(e2e): Add start of activity addition
cbc5d58 
Add first draft of a new E2E test with activities.
@RemIsMyWaifuu
chore(e2e): Ktfmt compliance
1feaa2e 
Ktfmt format compliance
@RemIsMyWaifuu RemIsMyWaifuu added the test Adding tests label Dec 11, 2024
@RemIsMyWaifuu RemIsMyWaifuu self-assigned this Dec 11, 2024
RemIsMyWaifuu and others added 18 commits December 11, 2024 16:22
@RemIsMyWaifuu
Merge branch 'main' into test/e2e-activity
30fee7f
@RemIsMyWaifuu
fix(e2e): Fix end to end test tags and display
93fff72 
Fix faulty test tags to make E2E work correctly.
@RemIsMyWaifuu
test(e2e): Expand E2E to edit an activity
30892a6 
Expand scope of E2E to handle activity edit and saving fields.
@RemIsMyWaifuu
chore(e2e): Ktfmt format compliance
a67a4f3 
Ktfmt format to comply with the linting standards.
@yassine04e
Merge branch 'main' into test/e2e-activity
b884209
@RemIsMyWaifuu
fix(e2e): Try to fix E2E conflicts
43a8307 
Try to fix E2E issues relating to shared firebase state.
@RemIsMyWaifuu
fix(e2e): Try to fix E2E errors
5e11dff 
Try to fix E2E issues relating with some strange stuff found on SO.
@RemIsMyWaifuu
test(e2e): Try to fix issues by refactor
378e0a2 
Try to see if putting tests in different packages affects results.
@RemIsMyWaifuu
test(e2e): Change email between E2E
2cdeaf7 
Change email between E2E but it doesn't help with the conflict state.
@yassine04e
Merge branch 'main' into test/e2e-activity
7e84da4
@yassine04e
fix: Unifying the emails acrros the e2e tests
3b98808
@yassine04e
deleting a user after travelCreationTravel e2e
7bb4838
@yassine04e
chore: adding diffrent timeouts in activity e2e to diffrenciate the f…
ce19784 
…ailure on the CI
@yassine04e
fix: correcting the test tag on the activity e2e when no activities p…
1cf1f0a 
…lanned
@yassine04e
fix: Downloading the firebase emulators with npm and not curl
666cc43
@RemIsMyWaifuu
test(e2e): Fix E2E tags due to refactor
2127110 
Fix E2E test tag by replacing it with the new proper name from main.
@RemIsMyWaifuu
chore(e2e): Rename test file
93380cf 
Rename ActivityCreationAndEdit by removing an unnecessary U.
Looks cleaner.
@yassine04e
fix: removing the test on the fields in activity e2e
d7b9f62
@RemIsMyWaifuu RemIsMyWaifuu linked an issue Dec 12, 2024 that may be closed by this pull request
E2E Activities test #253
Closed
@RemIsMyWaifuu RemIsMyWaifuu marked this pull request as ready for review December 12, 2024 23:38
@RemIsMyWaifuu
chore(e2e): Uncomment test tags and checks
a05985e 
Uncomment previously commented checks,
by providing the correct test tag.
@RemIsMyWaifuu
chore(e2e): Ktfmt format compliance
29369ba 
Ktfmt format in order to comply with the project's linting standards.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

appellet
appellet approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@appellet appellet left a comment •
edited by yassine04e
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really tried to look if I could not find an improvement or a change and I did not find any. The code of the e2e is really complete and efficient, so thank you for this work. This PR can be merged

@yassine04e yassine04e merged commit d4f7e22 into main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appellet appellet appellet approved these changes

Assignees

@RemIsMyWaifuu RemIsMyWaifuu

Labels
test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E Activities test
3 participants
@RemIsMyWaifuu @appellet @yassine04e