test: E2E #167
Merged
test: E2E #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemIsMyWaifuu
requested review from
RemIsMyWaifuu
and removed request for
RemIsMyWaifuu
…hilt injection (so creating mock repositories for profile and travel list, and a mock authentication service). The following things were added : 1) a mock repository for profileRepository 2) a mock repository for travelRepository 3) a mock database consisting of two maps, one mapping uid to profiles, and the other mapping uid to travels 4) using hilt to inject mock repositories in the view models of profile and travel 5) removing the factory for these view model 6) Adding an AppModule that helps us inject actual functions to use the firebase API calls and real repositories 7) Adding a TestModule that helps us inject mock API calls and mock repositories 8) Creating an adapter for authentication service and a mock authentication service 9) Adding a sign in model with email and password, to avoid dealing with google sign in
…ign in with email and password button due to the merging of the circular loading
…ss in NotificationRepositoryUnitTest by a data class it contains
…ing tests to verify the logic when clicking on the sign in button of SignInWithEmailAndPasswordScreen
…hanging the private val of NotificationRepository for a collection reference to a string (the collection reference is accessed from the fucntions now) This makes us avoid a Firestore Internal error when launching the e2e test
Closed
Unsaved2
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Great Work ! We have now a End to end test. I would have preferred that we use the Firebase emulator to do the end to end but I think you had problems with it so using Hilt is a very good way to do it.
Some suggestion in addition :
- Add Appmodule in a folder
di(Dependency Injection) - Add
ProfileRepositoryMock,TravelRepositoryMockin a folder mock - The sign button should be less visible because it is not the main option for sign in
- The screen for the Sign in with password can be maybe prettier ?
app/src/androidTest/java/com/github/se/travelpouch/endtoend/EndToEndTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/github/se/travelpouch/endtoend/EndToEndTest.kt
Show resolved
Hide resolved
...droidTest/java/com/github/se/travelpouch/ui/authentication/TestSignInWithEmailAndPassword.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/model/profile/ProfileModelView.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/model/travels/ListTravelViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/model/travels/TravelRepositoryMock.kt
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/authentication/SignInWithPassword.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/se/travelpouch/ui/authentication/SignInWithPassword.kt
Outdated
Show resolved
Hide resolved
|
To answer to your main comment :
|
…ders and back navigation, and adding the log in option with password refactor: Making the files in the correct directories, modules in di folders and TestSignInWithEmailAndPassword in unit Test
…ing tests for the UI with login with password and email
…lPouch/travelpouch into test/end-to-end-test-final-version
…conds style: removing useless logs in mock repositories
…alled the non-mock variable profileViewModel, but must call profileRepository which is mock
…h google, and blocking log in and sign in button on EmailAndPassword screen when a method of authentication is chosen, to avoid double authentication
…lPouch/travelpouch into test/end-to-end-test-final-version
|
Unsaved2
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.