Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mammalian Phenotype Ontology #300

Open
wants to merge 20 commits into
base: babel-1.9
Choose a base branch
from

Conversation

gaurav
Copy link
Collaborator

@gaurav gaurav commented Jul 1, 2024

This PR adds terms from the Mammalian Phenotype Ontology as requested by CAM-KP (#240). I added all the MP identifiers as well as mappings from https://github.com/mapping-commons/mh_mapping_initiative to connect it to HP and other identifiers. I added sssom as an explicit prerequisite so we can use it to read the SSSOM files in that GitHub repo, but that caused a lot of our other prerequisites to change (hence all the changes to requirements.lock).

We end up with 13,335 cliques that consist only of an MP identifier and 588 cliques that combine MP identifiers with other identifiers. We have no cases where an MP: identifier is chosen over other identifiers; the clique leaders we generate are:

  26 MESH
8498 EFO
13335 MP
16014 HP
19843 NCIT
315066 UMLS

There are a bunch of mapping issues, such as:

Ordinarily I would be nervous about including MP without more/better mappings, but since this isn't going to affect autocomplete (where we specifically filter to MONDO|HP) and that MP identifiers aren't (currently) clique leaders, I think we can merge this in now and then fix cliquing issues if anybody runs into issues with them (for now, probably only CAM-KP).

Closes #240.

WIP: see how often this new information merges cliques in ways we don't expect.

Should be merged after PR #365.

@gaurav gaurav changed the base branch from master to babel-1.6 July 1, 2024 02:00
@gaurav gaurav marked this pull request as ready for review August 13, 2024 07:35
@gaurav gaurav requested review from cbizon and removed request for cbizon August 13, 2024 07:35
Base automatically changed from babel-1.6 to master September 23, 2024 18:15
@gaurav gaurav changed the base branch from master to babel-1.9 November 5, 2024 07:26
@gaurav
Copy link
Collaborator Author

gaurav commented Dec 12, 2024

  • Message Nico and see if he knows of any mapping sources.
  • Talk to Chris about maybe allowing the MP IDs in now and fixing them later, maybe as part of an exact-label cleanup.
  • Give up and get rid of the MP-only cliques, so we only include MP identifiers if they combine with an existing clique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Mammalian Phenotype Ontology
1 participant